scales 1.0.0 log_breaks makes for inferior visual test (numeric-log.svg) in ggplot2

[dpseidel]

While approving the changes to ggplot2's visual tests (tidyverse/ggplot2#2842), @hadley requested that we review the change in numeric-log.svg cause by the improved log_breaks() functionality introduced in scales 1.0.0

This was the plot rendered with scales 0.5.0:

This is the current plot with scales 1.0.0:

The scale is behaving as expected but the additional major tick lines does make for a visually busier grid, especially given the use of theme_test() by default.

[mikmart]

Just as a bit of an "outsider" view, I like that the new base 10 log grid is consistent with a linear scale grid.

The visual tests have 1 and 10 000 on the log scale plot (so 5 orders of magnitude), resulting in 5 major grid lines; which is also what you would get when plotting 1 and 5 on a linear scale.

The new log-grid is certainly busier, but if it were to be adjusted, it feels to me that for the sake of consistency the same adjustment should also apply to a linear grid.

[hadley]

Hmmm looking at it again, I don't see what my problem was - the new display looks better to me. Maybe I got confused between the new and old plots?