Make sure cache objects don't affect RNG state #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29. I based this implementation on Shiny's
withPrivateSeed()function: https://github.com/rstudio/shiny/blob/78d77ce37/R/utils.R#L54-L88The one thing I didn't bring over was the call to
httpuv::getRNGState(), which was needed because of rstudio/shiny#1763. We probably need something like this in cases where an Rcpp function (in C++) calls this R code, though I don't know for sure right now.. If we implement this, we'll want to do it without bringing in an httpuv dependency or even Rcpp -- we'll want to implement it with C in the src/ directory.