fix: Only run single modal close step #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d8d917f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
commit: @qwik-ui/headless
|
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
I thing I might need to change is to check to see which is longer... like if animationDuration is longer than transitionDuration or vice versa, to close on the longer one. Thoughts? |
Contributor
|
That is an absolutely awesome first contribution @RumNCodeDev 🔥 |
maiieul
approved these changes
Jun 14, 2024
This was referenced Jul 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Why is it needed?
There was an issue where clicking onto the pane of the modal and pressing escape would cause future attempts at opening the modal to bug out.
Bug Link
After Fix
Checklist:
pnpm changeand documented my changes