Skip to content

Conversation

@at-the-vr
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests
  • Other

Why is it needed?

  • keeping brand logo up to date on docs

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have add necessary docs (if needed)
  • Added new tests to cover the fix / functionality

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2024

⚠️ No Changeset found

Latest commit: 2a132c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@at-the-vr
Copy link
Contributor Author

gonna have to ask for some time, first time around a CLA 😅

Copy link

@adaliszk adaliszk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@at-the-vr
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@maiieul
Copy link
Contributor

maiieul commented May 31, 2024

Hey @at-the-vr thanks so much for the PR.

What do you think about using the colored logo instead

image

Just a little preference on my end 🙈

@at-the-vr
Copy link
Contributor Author

The logo is in fact colored. I have made sure of it, sharing link to a loom recording for the changes. Working locally 💯, could appreciate if there was a Preview Build for everyone to review it properly

@maiieul
Copy link
Contributor

maiieul commented May 31, 2024

Oh it's in light mode that it's full black

image

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 31, 2024

Last Commit Build: 2a132c2

@qwik-ui/headless(2a132c2):

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@2a132c2    

Pull Request Build: #810

@qwik-ui/headless(#810):

npm i https://pkg.pr.new/qwikifiers/qwik-ui/@qwik-ui/headless@810    

@maiieul
Copy link
Contributor

maiieul commented May 31, 2024

I added the gradient to light mode as well. I'll ask them if it's problematic.. But then I'd have to think of another way to display the two meta-frameworks logo, cause the colored qwik-city next to the black Astro feels completely off imo..

@maiieul maiieul merged commit c3ed0d4 into qwikifiers:main May 31, 2024
@maiieul
Copy link
Contributor

maiieul commented May 31, 2024

Thanks again @at-the-vr 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: update Astro Logo in Installation Guide

3 participants