-
Notifications
You must be signed in to change notification settings - Fork 148
chore: update astro logo #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
gonna have to ask for some time, first time around a CLA 😅 |
adaliszk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I have read the CLA Document and I hereby sign the CLA |
|
Hey @at-the-vr thanks so much for the PR. What do you think about using the colored logo instead
Just a little preference on my end 🙈 |
|
The logo is in fact colored. I have made sure of it, sharing link to a loom recording for the changes. Working locally 💯, could appreciate if there was a Preview Build for everyone to review it properly |
|
I added the gradient to light mode as well. I'll ask them if it's problematic.. But then I'd have to think of another way to display the two meta-frameworks logo, cause the colored qwik-city next to the black Astro feels completely off imo.. |
|
Thanks again @at-the-vr 🙏 |


What is it?
Why is it needed?
Checklist:
pnpm changeand documented my changes