-
Notifications
You must be signed in to change notification settings - Fork 148
feat: add styled breadcrumb draft #665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 887689e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Looks good! @maiieul if you could double check since you work more on the styled kit, otherwise happy to merge. |
…tyle on BreadcrumbSeparator
|
First off, thanks a ton for this great PR @ditadi! I wouldn't have done such a great job with the My first impression is that the breadcrumb doesn't feel brutal enough in brutalist style. So I added a small commit to try and fix that. Would be awesome if you could review my changes @ditadi 🫶. It's the first time I commit on top of someone else's PR. We can always revert it if you (or anyone else) is against the changes. Also small nit pick: do you guys see any advantages in doing type BreadcrumbSeparatorProps = PropsOf<'li'>;
const BreadcrumbSeparator = component$<BreadcrumbSeparatorProps>((props) => {
return (
<li
role="presentation"
aria-hidden="true"
class={cn(
'[&>svg]:stroke-muted-foreground [&>svg]:size-3.5 [&>svg]:stroke-2',
props.class,
)}
{...props}
>
<LuChevronRight />
</li>
);
});Over type BreadcrumbSeparatorProps = PropsOf<'li'>;
const BreadcrumbSeparator = component$<BreadcrumbSeparatorProps>((props) => {
return (
<li role="presentation" aria-hidden="true" {...props}>
<LuChevronRight class="stroke-muted-foreground size-3.5 stroke-2" />
</li>
);
}); |
@maiieul About your Change: About the Style over |
|
Thanks for your feedback! Yeah I think the styles on the Icon's class are better in this case. Having them on the li would be useful if it was a Slot imo. |
What is it?
Why is it needed?
This PR adds a styled breadcrumb component. This way we can improve the navigation experience on applications using qwik-ui and increase the variety of components in the library.
Checklist:
pnpm changeand documented my changes