Skip to content

Conversation

sebastiandg7
Copy link
Contributor

@sebastiandg7 sebastiandg7 commented Feb 11, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Updates NxKit to v2.1.1 to include fix in nxkit/nxkit#59 allowing to install the packages dynamically.

Use cases and why

Screenshots/Demo

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Fixes #44

@sebastiandg7 sebastiandg7 force-pushed the fix/qwik-nx/nxkit-2.1.1-update branch from dd2c1af to b29eb3c Compare February 11, 2023 17:57
"baseUrl": ".",
"paths": {
"qwik-nx": ["packages/qwik-nx/src/index.ts"],
"@qwikifiers/e2e/utils": ["e2e/utils"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm nx format did it 🤠

Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko Feb 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not sure how this sneaked in, we have format in pre-commit 😅

@sebastiandg7 sebastiandg7 force-pushed the fix/qwik-nx/nxkit-2.1.1-update branch from b29eb3c to 8c9f5da Compare February 11, 2023 18:00
@sebastiandg7
Copy link
Contributor Author

Good to go now @dmitry-stepanenko!

Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sebastiandg7 !

@dmitry-stepanenko dmitry-stepanenko merged commit 2e1f4f6 into qwikifiers:main Feb 11, 2023
@sebastiandg7 sebastiandg7 deleted the fix/qwik-nx/nxkit-2.1.1-update branch February 11, 2023 18:07
reemardelarosa pushed a commit to reemardelarosa/qwik-nx that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

creating new nx workspace with preset=qwik-nx using pnpx throws an error

2 participants