Skip to content

Conversation

dmitry-stepanenko
Copy link
Contributor

@dmitry-stepanenko dmitry-stepanenko commented Dec 6, 2022

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

  • refactored application generator to scaffold a valid application within Nx workspace
  • updated library generator to rely on viteConfigurationGenerator from @nrwl/vite package

Use cases and why

Screenshots/Demo

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@dmitry-stepanenko dmitry-stepanenko force-pushed the ds/generator-enhancements branch from 1017357 to 4c500ba Compare December 6, 2022 15:32
@dmitry-stepanenko dmitry-stepanenko changed the title [WIP] feat: application & library generator updates feat: application & library generator updates Dec 6, 2022
@dmitry-stepanenko dmitry-stepanenko marked this pull request as ready for review December 6, 2022 15:33
@dmitry-stepanenko dmitry-stepanenko requested a review from a team December 6, 2022 15:33
@shairez
Copy link
Contributor

shairez commented Dec 7, 2022

thanks @dmitry-stepanenko !

@shairez shairez merged commit 5c6b7b9 into main Dec 7, 2022
@shairez shairez deleted the ds/generator-enhancements branch December 7, 2022 00:39
reemardelarosa pushed a commit to reemardelarosa/qwik-nx that referenced this pull request Dec 7, 2022
dmitry-stepanenko added a commit that referenced this pull request Dec 15, 2022
* feat(preset): feat: add "preset" generator: initial files

re #7

* fix(qwik-nx): fix build on new version (#11)

* feat: application & library generator updates (#5)

* chore(qwik-nx): release version 0.2.0

* fix: fix npm publish dist

dist folder in npm publish was pointing to the wrong folder

* chore(qwik-nx): release version 0.2.1

* fix: moved vite to dependencies (#12)

* Update README.md

* chore(qwik-nx): release version 0.2.2

* refactor(generator.ts): point generator to application

update projectDirectory, projectRoot, and projectType as an application"

fix #7

* feat(preset/files): added preset files"

added qwik application files to be use to create nx workspace

* feat(update generator.ts): update generator and schema

* docs(readme): added preset workspace

create nx with qwik-nx preset

* feat(preset): refactor generator

reuse application generator codes and interfaces

* refactor(generator): reuse applciation generator

reuse addFiles from application generator

* refactor(generator): reuse application generator

reuse existing generator and remove unnecessary codes

* fix: update schema props for preset

* fix: cleanup

* fix: cleanup

* fix: revert verdaccio guidelines

* style: added ▶

* fix: fix nexted folder for workspace preset

Co-authored-by: Shai Reznik <[email protected]>
Co-authored-by: Dmitriy Stepanenko <[email protected]>
Co-authored-by: @qwikifiers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants