Remove publisher finalize and shut down property a merge pipeline wit… #2263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h no corresponding indexing pipelines.
fulmicoton
reviewed
Nov 8, 2022
fulmicoton
approved these changes
Nov 8, 2022
The indexing pipeline updates its statistics on its finalize.
fulmicoton
force-pushed
the
fmassot--remove-merge-planner-exit-on-publisher-finalize--issues/2262
branch
2 times, most recently
from
6715314 to
6f59111
Compare
fulmicoton
force-pushed
the
fmassot--remove-merge-planner-exit-on-publisher-finalize--issues/2262
branch
from
6f59111 to
98eb074
Compare
fulmicoton
approved these changes
Nov 8, 2022
…her-finalize--issues/2262
fulmicoton
approved these changes
Nov 8, 2022
fmassot
deleted the
fmassot--remove-merge-planner-exit-on-publisher-finalize--issues/2262
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2262
I think we should also kill an indexing pipeline when we shut it down (but will see that in another PR).
2 tests added.