Refactor test_cmd_garbage_collect_spares_files_within_grace_period
#2169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please, add more asserts in your tests. Hitting the desired code path is not enough... |
guilload
reviewed
Oct 31, 2022
quickwit/quickwit-cli/tests/cli.rs
Outdated
|
|
||
| #[tokio::test] | ||
| async fn test_cmd_garbage_collect_spares_files_within_grace_period() -> Result<()> { | ||
| async fn test_cmd_garbage_collect_spares_files_within_grace_period() { |
Member
There was a problem hiding this comment.
Suggested change
| async fn test_cmd_garbage_collect_spares_files_within_grace_period() { | |
| async fn test_garbage_collect_index_cli() { |
quickwit/quickwit-cli/tests/cli.rs
Outdated
| data_dir: None, | ||
| }; | ||
|
|
||
| garbage_collect_index_cli(args).await.unwrap(); |
Member
There was a problem hiding this comment.
This needs to be followed by an assert...
quickwit/quickwit-cli/tests/cli.rs
Outdated
| let args = GarbageCollectIndexArgs { | ||
| config_uri: test_env.config_uri.clone(), | ||
| index_id: index_id.clone(), | ||
| grace_period: Duration::from_secs(2), |
Member
There was a problem hiding this comment.
We can probably shorten this to 1s
quickwit/quickwit-cli/tests/cli.rs
Outdated
|
|
||
| // Wait for grace period. | ||
| // TODO: edit split update timestamps and remove this sleep. | ||
| sleep(Duration::from_secs(3)).await; |
|
|
||
| Ok(()) | ||
| garbage_collect_index_cli(args).await.unwrap(); | ||
| assert_eq!(split_path.exists(), false); |
Member
There was a problem hiding this comment.
We need an assert on the number of splits in the metastore.
guilload
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.