Skip to content

Refactor test_cmd_dry_run_delete_on_s3_localstack #2167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Refactor test_cmd_dry_run_delete_on_s3_localstack #2167

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
180197e
Initial commit
boraarslan Oct 24, 2022
905ec3a
Merge branch 'main' into bora/refactor-cli-tests/delete-dry-run-s3
boraarslan Nov 7, 2022
36a45b6
Remove non-existent fields
boraarslan Nov 7, 2022
a0831ce
Delete the test
boraarslan Nov 7, 2022
1e83cba
Merge branch 'main' into bora/refactor-cli-tests/delete-dry-run-s3
boraarslan Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 0 additions & 61 deletions quickwit/quickwit-cli/tests/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,67 +710,6 @@ async fn test_garbage_collect_index_cli() {
assert_eq!(split_path.exists(), false);
}

#[tokio::test]
#[cfg_attr(not(feature = "ci-test"), ignore)]
async fn test_cmd_dry_run_delete_on_s3_localstack() -> Result<()> {
let index_id = append_random_suffix("test-delete-cmd--s3-localstack");
let test_env = create_test_env(index_id, TestStorageType::S3)?;
make_command(
format!(
"index create --config {} --index-config {}",
test_env.resource_files["config"].display(),
test_env.resource_files["index_config"].display()
)
.as_str(),
)
.assert()
.success();

ingest_docs(test_env.resource_files["logs"].as_path(), &test_env);

make_command(
format!(
"index gc --index {} --config {}",
test_env.index_id,
test_env.resource_files["config"].display(),
)
.as_str(),
)
.assert()
.success()
.stdout(predicate::str::contains(
"No dangling files to garbage collect",
));

make_command(
format!(
"index delete --index {} --config {} --dry-run",
test_env.index_id,
test_env.resource_files["config"].display(),
)
.as_str(),
)
.assert()
.success()
.stdout(predicate::str::contains(
"The following files will be removed",
))
.stdout(predicate::str::contains(".split"));

make_command(
format!(
"index delete --index {} --config {}",
test_env.index_id,
test_env.resource_files["config"].display(),
)
.as_str(),
)
.assert()
.success();

Ok(())
}

/// testing the api via cli commands
#[tokio::test]
async fn test_all_local_index() {
Expand Down