Mllama single qpc support added #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaddi
requested changes
Feb 3, 2025
| # Out-of-place Scatter new into old | ||
| # out-of-place is important so the original tensor is not affected, | ||
| # otherwise leads to same operations in both graphs | ||
| indices = (torch.arange(bsz),) |
There was a problem hiding this comment.
add a brief documentation on why these changes are required for single qpc and how does it create the graph.
There was a problem hiding this comment.
Sure, will update in final version.
| return outputs | ||
| return outputs | ||
|
|
||
| def generate_mllama_single(self, processor): |
There was a problem hiding this comment.
this is just required for the onnx export right?
There was a problem hiding this comment.
Yes, it is. As processor output varies model to model, this function will help to get the model specific processor output. Now I have also removed the dependency of processor by creating dummy inputs and made it generic for the single and dual qpcs.
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
quic-amitraj
force-pushed
the
mllama_single_qpc
branch
from
1378b1d to
a3271c1
Compare
Signed-off-by: Amit Raj <[email protected]>
Signed-off-by: Amit Raj <[email protected]>
quic-amitraj
force-pushed
the
mllama_single_qpc
branch
from
d2c879d to
67cb5ef
Compare
quic-amitraj
added a commit
that referenced
this pull request
Feb 10, 2025
1. Mllama single qpc support added 2. Simplified generate inputs for single and dual qpc --------- Signed-off-by: Amit Raj <[email protected]> Co-authored-by: asmigosw <[email protected]> Signed-off-by: Amit Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.