Skip to content

Conversation

@benfdking
Copy link
Collaborator

Add comprehensive support for advanced ClickHouse features:

  • Fix EXCEPT clause parsing conflict between SET operations and wildcard EXCEPT
  • Add REPLACE clause support for wildcard expressions
  • Add PREWHERE clause support for optimized filtering
  • Add AggregateFunction data type support
  • Add OPTIMIZE TABLE statement support
  • Add extensive test fixtures covering all new features

Technical changes:

  • Use LookaheadExclude to resolve EXCEPT parsing ambiguity
  • Extend WildcardExpressionSegment with EXCEPT and REPLACE clauses
  • Add PrewhereClauseSegment to SELECT statements
  • Add OptimizeTableStatementSegment with full syntax support
  • Add AggregateFunction to DatatypeSegment definitions

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

…OPTIMIZE TABLE support

Add comprehensive support for advanced ClickHouse features:

- Fix EXCEPT clause parsing conflict between SET operations and wildcard EXCEPT
- Add REPLACE clause support for wildcard expressions
- Add PREWHERE clause support for optimized filtering
- Add AggregateFunction data type support
- Add OPTIMIZE TABLE statement support
- Add extensive test fixtures covering all new features

Technical changes:
- Use LookaheadExclude to resolve EXCEPT parsing ambiguity
- Extend WildcardExpressionSegment with EXCEPT and REPLACE clauses
- Add PrewhereClauseSegment to SELECT statements
- Add OptimizeTableStatementSegment with full syntax support
- Add AggregateFunction to DatatypeSegment definitions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@github-actions
Copy link

Benchmark for b7546fa

Click to view benchmark
Test Base PR %
DepthMap::from_parent 61.1±0.82µs 60.8±0.80µs -0.49%
fix_complex_query 12.1±0.06ms 12.1±0.03ms 0.00%
fix_superlong 133.8±14.15ms 133.0±14.63ms -0.60%
parse_complex_query 4.3±0.03µs 4.1±0.05µs -4.65%
parse_expression_recursion 7.3±0.06µs 7.2±0.07µs -1.37%
parse_simple_query 1058.8±59.43ns 1033.7±6.23ns -2.37%

@openhands-ai
Copy link

openhands-ai bot commented Aug 27, 2025

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • PR Checks

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #1920 at branch `making_progress_on_clickhouse`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants