Skip to content

Conversation

jeremy9959
Copy link

@jeremy9959 jeremy9959 commented Dec 12, 2022

Description

Please describe your PR here.

I have added an algorithm environment to the list of theorem-like environments in theorems.lua.
This responds to my suggestion in #3605.

  alg = {
    env = "algorithm",
    style = "plain",
    title = "Algorithm",
  }

Checklist

I have (if applicable):

  • filed a contributor agreement.
  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog

@dragonstyle dragonstyle requested a review from cscheid March 2, 2023 13:24
@cscheid
Copy link
Collaborator

cscheid commented Mar 2, 2023

I apologize for not responding sooner. I'm reluctant to merge this PR as is, because this has a number of ramifications throughout our code base.

For example, we need to

  • ensure this works with crossrefs across all formats (this includes the latex crossref subsystem, and the quarto one, which is used in html, docx, etc)
  • ensure this works well with our localization infrastructure
  • works well with the templates we support

As it stands, our crossref infrastructure is fragile and I'm going to be rebuilding it entirely for 1.4. I'll keep the PR open to ensure we're tracking the issue, but I expect this will be solvable in a different way in the 1.4 system.

@cscheid cscheid added this to the v1.4 milestone Mar 2, 2023
@cscheid cscheid added enhancement New feature or request crossref labels Mar 2, 2023
@cscheid cscheid marked this pull request as draft March 2, 2023 16:05
@jeremy9959
Copy link
Author

I understand, I've made the change locally and it's working for me so in that sense my problem is solved. I'll keep an eye out for any unanticipated complications in which case I can report them.

@ghost ghost assigned cscheid May 11, 2023
@dragonstyle dragonstyle modified the milestones: v1.4, v1.5 Jan 25, 2024
@jeremy9959
Copy link
Author

Is this still a live issue? If not I will close it.

@cscheid
Copy link
Collaborator

cscheid commented Jun 12, 2024

Yes, it's still a live issue.

@cscheid cscheid modified the milestones: v1.5, Future Jun 27, 2024
@cscheid cscheid modified the milestones: Future, v1.8 Apr 7, 2025
@cscheid
Copy link
Collaborator

cscheid commented Apr 24, 2025

Took us long enough, but - I've remade this PR, added tests and we'll merge it early on in 1.8. Thanks for the contribution!

@cscheid
Copy link
Collaborator

cscheid commented Apr 24, 2025

I'm going to close this but we'll make sure to credit you in the 1.8 changelog once we merge.

@cscheid cscheid closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crossref enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants