-
Notifications
You must be signed in to change notification settings - Fork 52
Implement a compile time check of the Quarkus version #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This works as expected now, and this is an example produced StackTrace on a demo project:
|
Now the question becomes whether we want to enforce this or not… More specifically, should we be completely strict and require exact version matching or allow for some leeway… because, while the specific Quarkus version might have an impact, the real constraint is whether the fabric8 client version used by Quarkus is compatible with the version used by the bundled JOSDK version. So ideally, we'd need to compare these two versions. |
@metacosm the exception can now be avoided using a configuration value. If I'm not missing invariants with this approach we should finally be able to have an effective check in this and the user's codebases. |
Superseded by #478. |
This is a naive implementation of a compile time check for the Quarkus version.
Unfortunately the version returned from
quarkus.platform.version
is999-SNAPSHOT
and is not usable ...