Update verbose logging mechanism to enable callback provided by user #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync changes
latest changes
…-logic Expose detector order creation
Make simplex init_ilp private and remove binding
…ract-build Add CMake build system
…d-simplexconfig-for-verbose-callb feat: add verbose callback for decoders
Contributor
Author
|
not sure why the CI checks are failing 😕 it seems like they are getting cut off halfway |
Contributor
|
did you run the clang formatter on the code locally? ... the GitHub clang formatter can't parse the code |
Contributor
Author
Thanks, ran it! |
LalehB
approved these changes
Aug 6, 2025
| if (config.verbose) { | ||
| std::cout << "t0 = " << t0 << " t1 = " << t1 << std::endl; | ||
| } | ||
| config.log_stream << "t0 = " << t0 << " t1 = " << t1 << std::endl; |
Collaborator
There was a problem hiding this comment.
should we also have this: if (config.log_stream.active) { for this log_stream?
Contributor
NoureldinYosri
left a comment
NoureldinYosri
left a comment
There was a problem hiding this comment.
@noajshu do we want the callback solution or do you want to wait until I figure out the verbose thing?
| @@ -0,0 +1,101 @@ | |||
| cmake_minimum_required(VERSION 3.16) | |||
Contributor
There was a problem hiding this comment.
this change is unrelated to the functionality in the PR title
Contributor
Author
|
Abandoning this because #68 fixes the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored verbose logging mechanism to use a
CallbackStreamclass that can be given a callback handlerSince AI agents have trouble with Bazel, I added a CMake build system.
verbose_callback=None(the default) in the config ctor, it will be a no-op and all verbose logging will be disabled.