Skip to content

Migrate data loaders and related functions from pyfolio #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2017

Conversation

jameschristopher
Copy link
Contributor

@jameschristopher jameschristopher commented Aug 12, 2017

See this comment quantopian/alphalens#183 (comment) and PR for context on this PR. Also this empyrical issue #55

@jameschristopher jameschristopher changed the title start migration of fama-french related functions from pyfolio Migrate fama-french related functions from pyfolio Aug 12, 2017
@twiecki
Copy link
Contributor

twiecki commented Aug 14, 2017

@jameschristopher Thanks! Can you add the symbol (SPY) loaders too?

@jameschristopher
Copy link
Contributor Author

This should also allow pandas_datareader to be removed from the explicit pyfolio install reqs.

@jameschristopher jameschristopher changed the title Migrate fama-french related functions from pyfolio Migrate data loaders and related functions from pyfolio Aug 14, 2017
@twiecki
Copy link
Contributor

twiecki commented Aug 14, 2017

Looks great, thanks @jameschristopher! Want to do the PR to remove them from pyfolio?

@twiecki twiecki merged commit cfcd041 into quantopian:master Aug 14, 2017
@jameschristopher
Copy link
Contributor Author

already working on it :)

@eigenfoo
Copy link
Contributor

eigenfoo commented Aug 15, 2017

@twiecki @jameschristopher it may be better to simply deprecate the data loaders from pyfolio, instead of removing them entirely, and without warning. Easier for our open source users to pick up.

@jameschristopher
Copy link
Contributor Author

jameschristopher commented Aug 15, 2017 via email

@twiecki
Copy link
Contributor

twiecki commented Aug 15, 2017

I agree that it's a concern, however, we can just from empyrical import ... for the functions we moved and change the requirements.

@jameschristopher
Copy link
Contributor Author

Can we release a new version of empyrical so I can add that to the pyfolio requirements?

@eigenfoo
Copy link
Contributor

I'll also need a new version of empyrical for my alphalens PR @richafrank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants