-
Notifications
You must be signed in to change notification settings - Fork 440
Migrate data loaders and related functions from pyfolio #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jameschristopher Thanks! Can you add the symbol (SPY) loaders too? |
This should also allow |
Looks great, thanks @jameschristopher! Want to do the PR to remove them from pyfolio? |
already working on it :) |
@twiecki @jameschristopher it may be better to simply deprecate the data loaders from pyfolio, instead of removing them entirely, and without warning. Easier for our open source users to pick up. |
Removal will only affect new installations or updates, and as long as we
bump the empyrical version in the requirements this shouldn't introduce any
breaking changes
|
I agree that it's a concern, however, we can just |
Can we release a new version of empyrical so I can add that to the pyfolio requirements? |
I'll also need a new version of empyrical for my alphalens PR @richafrank |
See this comment quantopian/alphalens#183 (comment) and PR for context on this PR. Also this empyrical issue #55