Add check script for new entry to qcom-fitimage.its #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Can we add usage of the script in comments?
check-fitimage-metadata.sh
Outdated
| set -euo pipefail | ||
|
|
||
| ITS_FILE="qcom-fitimage.its" | ||
| META_FILE="qcom-metadata.dts" |
There was a problem hiding this comment.
Can we take the file path from user? If not provided, then fallback to these?
Usage:
- To verify that, for every substring in the comptables of each config added in the .its file, a corresponding subnode entry exists in the metadata.
For each configuration subnode in qcom-fitimage.its:
- read its "compatible" property
- strip "qcom," prefix
- split the remaining string on "-"
- verify that each resulting substring exists as a subnode name
in qcom-metadata.dts
Output:
- If everything passes: "success"
- If any missing: one line per miss:
fail <substring> <config_subnode_name>
Signed-off-by: Amrit Anand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each configuration subnode in qcom-fitimage.its:
Output: