Skip to content

disable host check for dev server #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 22, 2017
Merged

disable host check for dev server #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08277d3
use LABEL instead of MAINTAINER for Dockerfile
nighca Nov 22, 2017
014e5cf
disable host check for dev server
nighca Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM node:6.9.1
MAINTAINER nighca "[email protected]"
LABEL maintainer="[email protected]"

WORKDIR /fec

Expand Down
10 changes: 9 additions & 1 deletion lib/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,15 @@ const serve = port => getWebpackConfig().then(
webpackConfig => {
const host = '0.0.0.0'
const webpackDevServerConfig = _.extend(
{}, webpackConfig.devServer, { host, port }
{}, webpackConfig.devServer, {
host,
port,
// TODO: use false as default value?
// for there may be security risk
// https://github.com/webpack/webpack-dev-server/issues/882
// https://webpack.js.org/configuration/dev-server/#devserver-disablehostcheck
disableHostCheck: true
}
)

WebpackDevServer.addDevServerEntrypoints(webpackConfig, webpackDevServerConfig)
Expand Down