Skip to content

Attribute form size nestedforms #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Attribute form size nestedforms #519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30e21be
dynamic height for attribute form container
rsrg-zwiama Oct 31, 2025
0ef9b30
Merge branch 'qgis:master' into attribute_form_size_nestedforms
rsrg-zwiama Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions components/AttributeForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,11 +59,13 @@ class AttributeForm extends React.Component {
childEdit: null,
relationTables: {},
formValid: true,
captchaResponse: null
captchaResponse: null,
dynamicHeight: false
};
constructor(props) {
super(props);
this.form = null;
this.containerRef = React.createRef();
}
componentDidUpdate(prevProps, prevState) {
if (prevProps.editContext.changed !== this.props.editContext.changed) {
Expand Down Expand Up @@ -145,7 +147,7 @@ class AttributeForm extends React.Component {
readOnlyMsg = LocaleUtils.tr("editing.geomnonzeroz");
}
return (
<div className="AttributeForm">
<div className="AttributeForm" ref={this.containerRef} style={{height: this.state.childEdit ? `${this.state.dynamicHeight}px` : ""}}>
{readOnlyMsg ? (
<div className="attrib-form-geom-readonly">{readOnlyMsg}</div>
) : null}
Expand Down Expand Up @@ -299,6 +301,16 @@ class AttributeForm extends React.Component {
const editConfig = (this.props.theme.editConfig || {})[layer];
const feature = this.props.editContext.feature.relationValues[dataset].features[idx];
this.setState({childEdit: {action, editConfig, editContextId: ':' + layer, dataset, idx, feature, finishCallback: this.finishEditRelationRecord, displayField: displayField, hideDelete: true}});

if (!this.state.busy) {
const attributeFormContainer = this.containerRef.current;
if (attributeFormContainer) {
setTimeout(() => {
const qtForm = attributeFormContainer.querySelector(".link-feature-form-container .qt-designer-layout-grid") || attributeFormContainer.querySelector(".qt-designer-layout-grid");
this.setState({dynamicHeight: qtForm.scrollHeight + 100 || attributeFormContainer.scrollHeight + 100});
}, 50);
}
}
};
finishEditRelationRecord = (feature) => {
this.props.clearEditContext(this.state.childEdit.editContextId, this.props.editContext.id);
Expand All @@ -323,7 +335,7 @@ class AttributeForm extends React.Component {
const newFeature = {...this.props.editContext.feature, relationValues: newRelationValues};
this.props.setEditContext(this.props.editContext.id, {feature: newFeature, changed: changed});
}
this.setState({childEdit: null});
this.setState({childEdit: null, dynamicHeight: ""});
};
onDiscard = (action) => {
if (action === "Discard") {
Expand Down
Loading