Fix opensearch query parser #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also specify schema for id in arxiv-titles-384-angular filters dataset.
This is needed as default mapping created by opensearch takes the type
as float, but in the dataset we also have string.
This leads to 99% precision on the test dataset with opensearch.
```
{
"params": {
"dataset": "arxiv-titles-384-angular-filters",
"experiment": "opensearch-default",
"engine": "opensearch",
"parallel": 10,
"config": {
"knn.algo_param.ef_search": 128
}
},
"results": {
"total_time": 391.3466711850051,
"mean_time": 0.37053632343088827,
"mean_precisions": 0.98962,
"std_time": 0.3485163122349799,
"min_time": 0.04950378900684882,
"max_time": 3.548553360000369,
"rps": 25.552791773390613,
"p95_time": 1.0473700279486362,
"p99_time": 1.4396829416653787
}
}
```
Fixes qdrant#171
|
@KShivendu can you take a look? |
for more information, see https://pre-commit.ci
|
Thanks. Will check soon. |
KShivendu
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also specify schema for id in arxiv-titles-384-angular filters dataset. This is needed as default mapping created by opensearch takes the type as float, but in the dataset we also have string.
This leads to 99% precision on the test dataset with opensearch.
Fixes #171