-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add translate and RandomTranslate #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
===========================================
- Coverage 60.03% 37.98% -22.05%
===========================================
Files 64 33 -31
Lines 5054 3296 -1758
Branches 754 526 -228
===========================================
- Hits 3034 1252 -1782
- Misses 1817 1964 +147
+ Partials 203 80 -123
Continue to review full report at Codecov.
|
@ekagra-ranjan would be nice if you add some tests. |
@surgan12 Yup! Will add them. |
@fmassa Please have a look at the PR. |
Hi, What's the difference between |
If the user needs to randomly translate the image by some pixels then I think using @fmassa Your views on this? |
So, there was a PR in the past that already added a similar functionality #363 I was not convinced by then, because both performed the same thing in the end. |
I think it is the connotation of RandomCrop that can get people confused about its application. Maybe we can add translation as a use case in the docs of RandomCrop just like there is a mention about whitening in the LinearTransformation (now AffineTransformation)? |
@fmassa What are your views on addition of translation as a use case in RandomCrop? |
This PR adds translate and RandomTranslate as a separate transformation like the rotation transformation.