Skip to content

add end-to-end example gallery for transforms v2 #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 23, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 22, 2023

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass, looks good so far

@pmeier
Copy link
Collaborator Author

pmeier commented Feb 22, 2023

Rendered

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks Philip!
I have a bunch of minor comments below but nothing critical. I'll approve to unblock any follow-up, feel free to merge whenever

@pmeier
Copy link
Collaborator Author

pmeier commented Feb 23, 2023

Rendered

@pmeier
Copy link
Collaborator Author

pmeier commented Feb 23, 2023

@NicolasHug
Copy link
Member

That seems to be an existing problem, I observe the same for e.g. https://pytorch.org/vision/main/auto_examples/plot_transforms.html#sphx-glr-auto-examples-plot-transforms-py. Do you want to open an issue so we can keep track of this?

@pmeier
Copy link
Collaborator Author

pmeier commented Feb 23, 2023

See #7307.

@pmeier
Copy link
Collaborator Author

pmeier commented Feb 23, 2023

Rendered

@pmeier pmeier merged commit c786d75 into pytorch:main Feb 23, 2023
@pmeier pmeier deleted the transforms-e2e branch February 23, 2023 13:46
@@ -0,0 +1,152 @@
"""
==================================================
transforms v2: End-to-end object detection example
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late for the review.

- transforms v2: End-to-end object detection example
+ Transforms v2: End-to-end object detection example

import torchvision


# sphinx_gallery_thumbnail_number = -1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how we tell sphinx-gallery's to use the (last?) image for the thumbnail in this page
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remembered that there is an option to hide these kind of comments: https://sphinx-gallery.github.io/stable/configuration.html#removing-config-comments Will send a PR

NicolasHug added a commit to NicolasHug/vision that referenced this pull request Feb 24, 2023
facebook-github-bot pushed a commit that referenced this pull request Mar 29, 2023
Summary: Co-authored-by: Nicolas Hug <[email protected]>

Reviewed By: vmoens

Differential Revision: D44416601

fbshipit-source-id: b8c4e00edc0a461f8bb191ed6aebca7918bc975e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants