Split tests for transforms v2 and prototype #7278
Conversation
| return wrapper | ||
|
|
||
|
|
||
| def combinations_grid(**kwargs): |
There was a problem hiding this comment.
I've moved this to common_utils since it is no longer just used by the dataset tests.
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks Philip, obviously I can't review individual files, but the main lines above LGTM. One minor Q is about
Create test_datapoints and move everything non-label related there from test_prototype_transforms
Why move transforms-related tests into test_datapoints? Is there a typo?
Yes. It should say
Will update my top comment. |
|
Except for Python 3.8, all unittest jobs on macOS are failing due to insufficient resources on the runner: https://app.circleci.com/pipelines/github/pytorch/vision/23382/workflows/05e31fc3-0271-4ad4-8d48-a0b82b3e099f/jobs/1834265?invite=true#step-109-223. We are using vision/.circleci/config.yml.in Line 904 in dfa81ce which translates to
There is also
Will try this one. |
|
Unittest on Windows and Linux are green though, so I'' revert 67fdc6d. |
…espace" This reverts commit 67fdc6d.
…o split-v2-tests
|
It seems we don't have access to the larger runner: https://app.circleci.com/pipelines/github/pytorch/vision/23385/workflows/979cac8c-f706-44cc-8a7b-8102a58ebbe4/jobs/1834346
|
Reviewed By: vmoens Differential Revision: D44416542 fbshipit-source-id: 7ed18b0218f1b65aa1f7b016f56777e55207ac53
3 participants
With the branch cut coming around the
torchvision/prototypenamespace will be removed for the release branch. Right now all the tests for the migratedtorchvision.datapointsandtorchvision.transforms.v2unconditionally import fromtorchvision.prototypeand thus will fail. This PR does the following:prototype_common_utilsintocommon_utils. The only things remain inprototype_common_utilsis the label and one hot label data generationtest_datapointsand move everything non-label related there fromtest_prototype_datapointsprototype_transforms_{kernel,dispatcher}_infosandtest_prototype_transforms_{functional,utils}into*transforms_v2*test_transforms_v2and move most oftest_prototype_transformsthere. Some things like batch or video transforms stay intest_prototype_transformstest_prototype_transforms_consistencytotest_transforms_v2_consistencyand remove all label related stuff. Furthermore, move test forFixedSizedCroptotest_prototype_transforms.cc @vfdev-5 @bjuncek