-
Notifications
You must be signed in to change notification settings - Fork 7.1k
add proper smoke test for prototype transforms #7238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments already discussed offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
As discussed offline and as a follow-up we should try to validate that the degenerate bboxes stay degenerate (or potentially passed-through), although this may involve a mechanism we don't have yet
Reviewed By: vmoens Differential Revision: D44416579 fbshipit-source-id: 9c3b0da79fe1270c13b6f705c5894ddd7783911f
Per title. We test two things:
We test this against a plethora of configurations:
datapoints.Image
,datapoints.Video
,PIL.Image.Image
, plaintorch.Tensor
as "core" inputApart from the "core" input, by default each sample contains more images and videos, bounding boxes in all formats (regular and degenerate ones), detection and segmentation masks, Python builtin types (
int
,str
), other objects (pathlib.Path
), a plain tensor, and anumpy
array.cc @vfdev-5 @bjuncek