Skip to content

add tests for the output types of prototype functional dispatchers #7118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Jan 20, 2023

Addresses #7113 (comment). Contrary to my believe, we currently don't have any automated tests that enforce that the output type of a dispatcher is the same as the input type. This PR corrects that.

cc @vfdev-5 @bjuncek

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pmeier

@pmeier pmeier merged commit d2d448c into pytorch:main Jan 20, 2023
@pmeier pmeier deleted the test-output-type branch January 20, 2023 12:12
facebook-github-bot pushed a commit that referenced this pull request Jan 24, 2023
…tchers (#7118)

Reviewed By: YosuaMichael

Differential Revision: D42706904

fbshipit-source-id: 6f5da4914fd5d30cf6ef575ce6a1266e2012157b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants