Skip to content

Remove performance workaround for mask resize #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 10, 2022
Merged

Remove performance workaround for mask resize #6729

merged 8 commits into from
Oct 10, 2022

Conversation

datumbox
Copy link
Contributor

Removing performance workaround now that the pytorch/pytorch#83840 is resolved.

@datumbox datumbox requested a review from vfdev-5 October 10, 2022 08:34
pmeier
pmeier approved these changes Oct 10, 2022
View reviewed changes
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the sample inputs that tested this specific branch:

vision/test/prototype_transforms_kernel_infos.py

Lines 252 to 260 in af54e56

# We have a speed hack in place for nearest interpolation and single channel images (grayscale)
for image_loader in make_image_loaders(
sizes=["random"],
color_spaces=[features.ColorSpace.GRAY],
extra_dims=VALID_EXTRA_DIMS,
):
yield ArgsKwargs(
image_loader, size=[min(image_loader.image_size) + 1], interpolation=F.InterpolationMode.NEAREST
)

Otherwise LGTM if CI is green.

@datumbox datumbox merged commit 0ab50f5 into pytorch:main Oct 10, 2022
@datumbox datumbox deleted the prototype/remove_resize_workaround branch October 10, 2022 11:32
datumbox added a commit that referenced this pull request Oct 11, 2022
@datumbox
Revert "Remove performance workaround for mask resize (#6729)"
9a8b1b7 
This reverts commit 0ab50f5.
@datumbox datumbox mentioned this pull request Oct 11, 2022
Closed
@datumbox datumbox added revert(ed) For reverted PRs, and PRs that revert other PRs and removed revert(ed) For reverted PRs, and PRs that revert other PRs labels Oct 11, 2022
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
@facebook-github-bot
[fbsync] Remove performance workaround for mask resize (#6729)
8543a62 
Summary:
* Remove performance workaround for mask resize

* Fix linter

* bug fixes

* remove unnecessary import

* Fixing linter

Reviewed By: NicolasHug

Differential Revision: D40427473

fbshipit-source-id: e7e632069c62cc4e53c31571f0c177d68ee61c3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmeier pmeier pmeier approved these changes

@NicolasHug NicolasHug NicolasHug approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
cla signed code quality module: transforms prototype
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datumbox @NicolasHug @pmeier @facebook-github-bot