[prototype] Rewrite the meta dimension methods #6722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 17, 2022
Summary: * Rewrite `get_dimensions`, `get_num_channels` and `get_spatial_size` * Remove `get_chw` * Remove comments * Make `get_spatial_size` support non-image input * Reduce the unnecessary use of `get_dimensions*` * Fix linters * Fix merge bug * Linter * Fix linter Reviewed By: NicolasHug Differential Revision: D40427457 fbshipit-source-id: 3bf165ee130216047c3dc1dc671454e211d73855
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6491
This PR:
get_chwutility in favour ofget_dimensionsget_num_channelsandget_spatial_sizeget_spatial_sizeto support bboxes, masks etcThis is in preparation of removing the overuse of
query_chwfrom the transforms to support single bboxes/masks without images/videos. The renaming ofimage_sizetospatial_sizewill happen on a follow up PR.