Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Oct 5, 2022

Follow-up to #6653 (comment) and #6653 (comment).

This includes multiple small things as well as the refactoring of KernelInfo and DispatcherInfo away from dataclasses.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me, thanks @pmeier !

@pmeier pmeier merged commit 3f1d9f6 into pytorch:main Oct 10, 2022
facebook-github-bot pushed a commit that referenced this pull request Oct 17, 2022
Summary:
* make args and kwargs in ArgsKwargs more accessible

* refactor KernelInfo and DispatcherInfo

* remove ArgsKwargs __getitem__ shortcut again

Reviewed By: NicolasHug

Differential Revision: D40427470

fbshipit-source-id: b26d57a060df767754649ae03aea80323fc51b1d
@pmeier pmeier deleted the proto-test-cleanup branch November 25, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants