-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Bugfix for accimage test on functional_pil.resize image #6208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix for accimage test on functional_pil.resize image #6208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Since our CI doesn't check for accimage (maybe it should, potential improvement for when we review our testing strategy), would you be able to offer proof that the test passes using accimage locally or on the dev server?
Yeah, I will take note about this for potential improvement on our testing CI. I have tested it on dev server in AWS with accimage installed. Here is the test result: For the test_accimage_resize only:
For all transforms
|
@YosuaMichael thanks for fixing and sorry the bug ! In the PR introduced the type change it was tricky to please mypy and jit with Tuples |
@vfdev-5 just to confirm, this function don't need to be jit scriptable right? (I saw it has @torch.jit.unused decorator). Also no worry about it, this is quite tricky since the CI dont cover accimage and it only fail on accimage (luckily the internal test actually test on accimage and thats why I can catch it) |
@YosuaMichael right this function can't be jit scriptable but I was refactoring some common code into |
Reviewed By: datumbox Differential Revision: D37460134 fbshipit-source-id: 921a3fa562f543f0a0fefbd6e57d1ea24781d26c
Addressing #6207
(the bug is introduced on #6191 )