Skip to content

Fix edge cases on test_backbone_utils when the sampled node is buffer with integer value #6091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

YosuaMichael
Copy link
Contributor

Cherry pick #6090 from main into release/0.13

@YosuaMichael
Copy link
Contributor Author

The type check failed, but seems like it is not related with this PR. It affect all the model loading. Will investigate...

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like the breakage is completely unrelated. Possibly due to a change on Core??? I recommend prior merging this PR to open a dummy PR against the release branch to confirm.

@YosuaMichael
Copy link
Contributor Author

Seems like the problem in typecheck is not because of this PR: #6092
I have created this dummy PR to check.

I am not too sure what cause this problem, but I have a fix for the type check, will create separate PR for it

@datumbox
Copy link
Contributor

The problem is not on your side. We should merge this and review the issue on a separate PR.

@datumbox datumbox merged commit 24508c0 into pytorch:release/0.13 May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants