Fix test_backbone_utils by adding .float() before .mean() #6090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dont accept integer dtype
datumbox
approved these changes
May 25, 2022
There was a problem hiding this comment.
LGTM, thanks @YosuaMichael. Feel free to merge once the CI is green.
YosuaMichael
added a commit
to YosuaMichael/vision
that referenced
this pull request
May 25, 2022
… dont accept integer dtype (pytorch#6090)
This was referenced May 25, 2022
Merged
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 1, 2022
…e .mean() dont accept integer dtype (#6090) Reviewed By: NicolasHug Differential Revision: D36760937 fbshipit-source-id: dfe3ef93953f9f7d4e55cefa40f177e574a5271f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test_backbone_utils.TestFxFeatureExtraction, there is edge case when the sampled nodes are buffer and does not depend on input and has integer value (example on swin transformer).
In this case, the test will trigger error because
Tensor.meandoes not acceptinteger.This PR provide a fix by adding
.float()before.mean().