Skip to content

fix missing torchdata error message #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2022
Merged

fix missing torchdata error message #5738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e065543
fix missing torchdata error message
pmeier Apr 5, 2022
5f0200b
Merge branch 'main' into fix-torchdata-msg
pmeier Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions torchvision/prototype/datasets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
try:
import torchdata
except (ModuleNotFoundError, TypeError) as error:
except ModuleNotFoundError:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the TypeError here since that was the error type of the legacy torchdata package hosted on PyPI. Since we took over the name, pip install torchdata will give you the correct package.

raise ModuleNotFoundError(
"`torchvision.prototype.datasets` depends on PyTorch's `torchdata` (https://github.com/pytorch/data). "
"You can install it with `pip install git+https://github.com/pytorch/data.git`. "
"Note that you cannot install it with `pip install torchdata`, since this is another package."
) from error
"You can install it with `pip install --pre torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu"
) from None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason not to raise from error like before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the removal of the TypeError, showing the excepted error adds no information:

try:
    import foo
except ImportError as error:
    raise ModuleNotFoundError("foo is not available") from error
Traceback (most recent call last):
  File "main.py", line 2, in <module>
    import foo
ModuleNotFoundError: No module named 'foo'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "main.py", line 4, in <module>
    raise ModuleNotFoundError("foo is not available") from error
ModuleNotFoundError: foo is not available

vs.

try:
    import foo
except ImportError as error:
    raise ModuleNotFoundError("foo is not available")
Traceback (most recent call last):
  File "main.py", line 2, in <module>
    import foo
ModuleNotFoundError: No module named 'foo'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 4, in <module>
    raise ModuleNotFoundError("foo is not available")
ModuleNotFoundError: foo is not available

vs.

try:
    import foo
except ImportError as error:
    raise ModuleNotFoundError("foo is not available") from None
Traceback (most recent call last):
  File "main.py", line 4, in <module>
    raise ModuleNotFoundError("foo is not available") from None
ModuleNotFoundError: foo is not available


from . import utils
from ._home import home
Expand Down