Skip to content

fix missing torchdata error message #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Apr 5, 2022

I missed that in #5672.

@@ -1,11 +1,10 @@
try:
import torchdata
except (ModuleNotFoundError, TypeError) as error:
except ModuleNotFoundError:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the TypeError here since that was the error type of the legacy torchdata package hosted on PyPI. Since we took over the name, pip install torchdata will give you the correct package.

"Note that you cannot install it with `pip install torchdata`, since this is another package."
) from error
"You can install it with `pip install --pre torchdata --extra-index-url https://download.pytorch.org/whl/nightly/cpu"
) from None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason not to raise from error like before?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the removal of the TypeError, showing the excepted error adds no information:

try:
    import foo
except ImportError as error:
    raise ModuleNotFoundError("foo is not available") from error
Traceback (most recent call last):
  File "main.py", line 2, in <module>
    import foo
ModuleNotFoundError: No module named 'foo'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "main.py", line 4, in <module>
    raise ModuleNotFoundError("foo is not available") from error
ModuleNotFoundError: foo is not available

vs.

try:
    import foo
except ImportError as error:
    raise ModuleNotFoundError("foo is not available")
Traceback (most recent call last):
  File "main.py", line 2, in <module>
    import foo
ModuleNotFoundError: No module named 'foo'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "main.py", line 4, in <module>
    raise ModuleNotFoundError("foo is not available")
ModuleNotFoundError: foo is not available

vs.

try:
    import foo
except ImportError as error:
    raise ModuleNotFoundError("foo is not available") from None
Traceback (most recent call last):
  File "main.py", line 4, in <module>
    raise ModuleNotFoundError("foo is not available") from None
ModuleNotFoundError: foo is not available

@pmeier pmeier merged commit d0c92dc into pytorch:main Apr 5, 2022
@pmeier pmeier deleted the fix-torchdata-msg branch April 5, 2022 10:24
facebook-github-bot pushed a commit that referenced this pull request May 5, 2022
Summary: (Note: this ignores all push blocking failures!)

Reviewed By: jdsgomes, NicolasHug

Differential Revision: D36095676

fbshipit-source-id: 2192ec444667dbf20e41ddd336d186f010e9bfbf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants