Skip to content

Try to fix lint/mypy failed CI #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2022
Merged

Try to fix lint/mypy failed CI #5598

merged 2 commits into from
Mar 11, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Mar 11, 2022 •
edited
Loading

@facebook-github-bot
Copy link

facebook-github-bot commented Mar 11, 2022 •
edited
Loading

💊 CI failures summary and remediations

As of commit c5780ca (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

datumbox
datumbox approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@datumbox datumbox merged commit 8aadef5 into pytorch:main Mar 11, 2022
@github-actions
Copy link

Hey @datumbox!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@datumbox datumbox added the other if you have no clue or if you will manually handle the PR in the release notes label Mar 11, 2022
@vfdev-5 vfdev-5 deleted the try-fix-mypy branch March 11, 2022 19:10
@federicopozzi33 federicopozzi33 mentioned this pull request Mar 12, 2022
Closed
@pmeier
Copy link
Collaborator

pmeier commented Mar 13, 2022 •
edited
Loading

We should really pin the mypy version:

vision/.circleci/config.yml.in

Lines 309 to 310 in 27745e5

- pip_install:
args: mypy

It seems we are getting failures for every new release.

facebook-github-bot pushed a commit that referenced this pull request Mar 15, 2022
@datumbox @facebook-github-bot
[fbsync] Try to fix lint/mypy failed CI (#5598)
ac49389 
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]>

Reviewed By: vmoens

Differential Revision: D34878975

fbshipit-source-id: defc91bc37d73964203310633b07def1a0d9f4b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed other if you have no clue or if you will manually handle the PR in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vfdev-5 @facebook-github-bot @pmeier @datumbox