Skip to content

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Feb 23, 2022

These functional only support tensors, but are implemented in functional nonetheless. This PR moves the functionality to functional_tensor to have all tensor kernels in the same place. First step towards addressing #5421 (comment).

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 23, 2022

💊 CI failures summary and remediations

As of commit 0d82d9f (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pmeier pmeier merged commit efb0736 into pytorch:main Feb 23, 2022
@pmeier pmeier deleted the refactor-functional branch February 23, 2022 14:04
facebook-github-bot pushed a commit that referenced this pull request Feb 25, 2022
Summary:
* add tensor kernels for normalize and erase

* add image tensor assertion

Reviewed By: jdsgomes

Differential Revision: D34475322

fbshipit-source-id: acf8ac9e94b6e6bded0e4a17739126af522c51f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants