Skip to content

Updated gpu decoder test to use parametrize #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

prabhat00155
Copy link
Contributor

Use parametrize instead of looping over the list. This would help point out the exact scenario in case of failures.

@facebook-github-bot
Copy link

facebook-github-bot commented Feb 1, 2022

💊 CI failures summary and remediations

As of commit 2fc7a71 (more details on the Dr. CI page):


  • 2/2 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See GitHub Actions build CodeQL / build (1/1)

Step: "Build TorchVision" (full log | diagnosis details | 🔁 rerun)

2022-02-01T13:50:27.8589121Z ##[error]Process completed with exit code 1.
2022-02-01T13:50:27.6899779Z     self.finalize_options()
2022-02-01T13:50:27.6900386Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/develop.py", line 52, in finalize_options
2022-02-01T13:50:27.6901126Z     easy_install.finalize_options(self)
2022-02-01T13:50:27.6901737Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 276, in finalize_options
2022-02-01T13:50:27.6902262Z     self._fix_install_dir_for_user_site()
2022-02-01T13:50:27.6902889Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 382, in _fix_install_dir_for_user_site
2022-02-01T13:50:27.6903370Z     self.create_home_path()
2022-02-01T13:50:27.6904122Z   File "/home/runner/.local/lib/python3.8/site-packages/setuptools/command/easy_install.py", line 1338, in create_home_path
2022-02-01T13:50:27.6904597Z     if path.startswith(home) and not os.path.isdir(path):
2022-02-01T13:50:27.6905168Z AttributeError: 'int' object has no attribute 'startswith'
2022-02-01T13:50:27.8589121Z ##[error]Process completed with exit code 1.
2022-02-01T13:50:27.8676825Z Post job cleanup.
2022-02-01T13:50:27.9858443Z [command]/usr/bin/git version
2022-02-01T13:50:27.9916037Z git version 2.34.1
2022-02-01T13:50:27.9956693Z [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
2022-02-01T13:50:28.0006205Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :
2022-02-01T13:50:28.0370247Z [command]/usr/bin/git config --local --name-only --get-regexp http\.https\:\/\/github\.com\/\.extraheader
2022-02-01T13:50:28.0398106Z http.https://github.com/.extraheader
2022-02-01T13:50:28.0409494Z [command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
2022-02-01T13:50:28.0455203Z [command]/usr/bin/git submodule foreach --recursive git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :
2022-02-01T13:50:28.1016051Z Cleaning up orphan processes

1 failure not recognized by patterns:

Job Step Action
CircleCI cmake_macos_cpu curl -o conda.sh https://repo.anaconda.com/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
sh conda.sh -b
source $HOME/miniconda3/bin/activate
conda install -yq conda-build cmake
packaging/build_cmake.sh
🔁 rerun

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prabhat00155 , LGTM.

@prabhat00155 prabhat00155 merged commit eba853e into pytorch:main Feb 1, 2022
@prabhat00155 prabhat00155 deleted the prabhat00155/update_gpu_test branch February 1, 2022 13:55
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Hey @prabhat00155!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

facebook-github-bot pushed a commit that referenced this pull request Feb 3, 2022
Summary:
* Updated gpu decoder test to use parametrize

* Remove list comprehension

Reviewed By: kazhang

Differential Revision: D33927498

fbshipit-source-id: 731b998f24ac12f6f68e73109f27cf07ece388e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants