-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Mino simplifications to prototype dataset testings #5268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💊 CI failures summary and remediationsAs of commit 14acd48 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot @NicolasHug!
Summary: Add `register_mock` decorator to prototype dataset testing. Reviewed By: kazhang Differential Revision: D33927507 fbshipit-source-id: 62eedf24d12d3ddc91bde8bf21acc31ffe26f6de
This PR contains a few simplifications to the prototype dataset test suite as discussed offline with @pmeier