Skip to content

Resnext #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Resnext #361

wants to merge 4 commits into from

Conversation

csarofeen
Copy link

Add ResNeXt to models.

@fmassa
Copy link
Member

fmassa commented Dec 12, 2017

I think this looks good, thanks @csarofeen!
Quick question: do we have pre-trained models for resnext?

@skrish13
Copy link
Contributor

@fmassa quick clarification, we'd need trained models with weights required to be added to PyTorch models right? (and not just the network arch) (takeaway from the discussion #260)

We can add that point to the README for guidelines towards contributing (will save time rejecting ones which dont follow them and also save effort for people who are writing and unaware)

Is there any unofficial library of sorts where we can compile different papers implementations in PyTorch, if so, we can redirect appropriate PRs like these there too!

@fmassa
Copy link
Member

fmassa commented Dec 14, 2017

@skrish13 yes, we should add a mention to the README saying that the models should ideally be trained using the imagenet example with the same mean/std and preprocessing, so that the models are easily reproducible by others.

There are a number of repos with pytorch models.
One that comes to mind is https://github.com/Cadene/pretrained-models.pytorch, which has pre-trained pytorch models for which the weights were converted to pytorch from the original implementation.

But I do believe we should have some newer models that are proven to be better under the same training tricks, so that users have a good idea if the models are indeed better because of the architecture or just because of more tricks during training.

@fmassa
Copy link
Member

fmassa commented May 7, 2019

This has been implemented in master, and I'm in the process of adding pre-trained weights. Thanks for the PR @csarofeen !

@fmassa fmassa closed this May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants