[v0.9.1] Remove special versioning suffix rules for CUDA 10.2 #3603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a version suffix for CUDA 10.2 for ease of installing when installing from download.pytorch.org Signed-off-by: Eli Uriegas <[email protected]>
seemethere
changed the title
walterddr
approved these changes
Mar 24, 2021
xuzhao9
approved these changes
Mar 24, 2021
packaging/pkg_helpers.bash
Outdated
| @@ -36,9 +36,7 @@ setup_cuda() { | |||
| # Wheel builds need suffixes (but not if they're on OS X, which never has suffix) | |||
| if [[ "$BUILD_TYPE" == "wheel" ]] && [[ "$(uname)" != Darwin ]]; then | |||
| # The default CUDA has no suffix | |||
There was a problem hiding this comment.
Should we remove this comment as well since all CUDA versions have a suffix now?
malfet
approved these changes
Mar 24, 2021
malfet
reviewed
Mar 24, 2021
packaging/pkg_helpers.bash
Outdated
| @@ -36,9 +36,7 @@ setup_cuda() { | |||
| # Wheel builds need suffixes (but not if they're on OS X, which never has suffix) | |||
| if [[ "$BUILD_TYPE" == "wheel" ]] && [[ "$(uname)" != Darwin ]]; then | |||
| # The default CUDA has no suffix | |||
There was a problem hiding this comment.
Agree with @xuzhao9, we should remove the comment
Suggested change
| # The default CUDA has no suffix |
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
remove_special_versioning
branch
from
2154dbd to
eb9607e
Compare
Signed-off-by: Eli Uriegas <[email protected]>
fmassa
reviewed
Mar 25, 2021
| # The default CUDA has no suffix | ||
| if [[ "$CU_VERSION" != "cu102" ]]; then | ||
| export PYTORCH_VERSION_SUFFIX="+$CU_VERSION" | ||
| fi | ||
| export PYTORCH_VERSION_SUFFIX="+$CU_VERSION" |
There was a problem hiding this comment.
Should we cherry-pick this change to the master branch?
There was a problem hiding this comment.
Yes, I'll make follow up PRs for both things here
seemethere
added a commit
that referenced
this pull request
Jun 15, 2021
* packaging: Remove special versioning priveleges Adds a version suffix for CUDA 10.2 for ease of installing when installing from download.pytorch.org Signed-off-by: Eli Uriegas <[email protected]> * also include windows cmath fix Signed-off-by: Eli Uriegas <[email protected]> * remove comment Signed-off-by: Eli Uriegas <[email protected]> * fix indent Signed-off-by: Eli Uriegas <[email protected]> * actually add the script Signed-off-by: Eli Uriegas <[email protected]>
seemethere
added a commit
to seemethere/vision
that referenced
this pull request
Jun 15, 2021
…h#3603) * packaging: Remove special versioning priveleges Adds a version suffix for CUDA 10.2 for ease of installing when installing from download.pytorch.org Signed-off-by: Eli Uriegas <[email protected]> * also include windows cmath fix Signed-off-by: Eli Uriegas <[email protected]> * remove comment Signed-off-by: Eli Uriegas <[email protected]> * fix indent Signed-off-by: Eli Uriegas <[email protected]> * actually add the script Signed-off-by: Eli Uriegas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coincides with pytorch/pytorch#53133
Signed-off-by: Eli Uriegas [email protected]