Skip to content

Normalize single images to make_grid #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2017
Merged

Normalize single images to make_grid #360

merged 1 commit into from
Dec 6, 2017

Conversation

yannadani
Copy link
Contributor

Fixes #350.

@alykhantejani
Copy link
Contributor

Thanks @yannadani!

@alykhantejani alykhantejani merged commit ff3f738 into pytorch:master Dec 6, 2017
@fmassa
Copy link
Member

fmassa commented Jan 31, 2018

While I'm ok with this change, if the user passed a 4D Tensor where the size of the first dimension is 1, then the returned image would have 3 dimensions, which might not be expected.

@alykhantejani alykhantejani mentioned this pull request Feb 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yannadani @alykhantejani @fmassa