EMNIST dataset + speedup *MNIST preprocessing #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alykhantejani
approved these changes
Dec 5, 2017
torchvision/datasets/mnist.py
Outdated
|
|
||
| def __init__(self, root, split, **kwargs): | ||
| if split not in self.splits: | ||
| raise RuntimeError('Split "{}" not found. Valid splits are: {}'.format( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thanks @martinraison - especially for the speedup! |
rajveerb
pushed a commit
to rajveerb/vision
that referenced
this pull request
Nov 30, 2023
* minigo updates for 0.7 * Delete CODE_OF_CONDUCT.md * Delete CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to add support for the recently released EMNIST dataset (https://www.nist.gov/itl/iad/image-group/emnist-dataset)
The data format is similar to
MNISTso I subclassedMNIST(likeFashionMNISTdid before). There are 6 splits in the dataset and everything is zipped up inside a single archive, which is why I had to override__init__anddownload.I also noticed that
read_image_filecurrently parses data byte by byte, which is very slow. Usingnp.frombufferspeeds up preprocessing by a factor 1000x (so preprocessing takes < 1sec instead of several minutes).