Skip to content

Unified inputs for T.RandomRotation #2496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 7, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Jul 21, 2020

Related to #2292

Description:

  • Added code for T.RandomRotation with tests and docs

Blocked by #2553

@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #2496 into master will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2496      +/-   ##
==========================================
- Coverage   71.81%   71.77%   -0.05%     
==========================================
  Files          94       94              
  Lines        8080     8088       +8     
  Branches     1282     1287       +5     
==========================================
+ Hits         5803     5805       +2     
- Misses       1868     1871       +3     
- Partials      409      412       +3     
Impacted Files Coverage Δ
torchvision/transforms/functional.py 80.11% <ø> (ø)
torchvision/transforms/transforms.py 75.52% <60.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 025b71d...d3aa1db. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

Let's wait until the rotate is merged before merging this one

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Aug 6, 2020

@fmassa as #2553 is merged, I updated this PR accordingly and it is ready for review.

@fmassa fmassa merged commit 08af5cb into pytorch:master Aug 7, 2020
@vfdev-5 vfdev-5 mentioned this pull request Aug 7, 2020
16 tasks
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
* Added code for F_t.rotate with test
- updated F.affine tests

* Rotate test tolerance to 2%

* Fixes failing test

* [WIP] RandomRotation

* Unified RandomRotation with tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants