PR: Improve handling of truncated/incomplete and corrupt JPEG images #2471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
approved these changes
Jul 15, 2020
| // No more data. Probably an incomplete image; Raise exception. | ||
| torch_jpeg_error_ptr myerr = (torch_jpeg_error_ptr)cinfo->err; | ||
| strcpy(jpegLastErrorMsg, "Image is incomplete or truncated"); | ||
| longjmp(myerr->setjmp_buffer, 1); |
There was a problem hiding this comment.
Thanks for fixing this!
For future reference, here is how TensorFlow implements this function. I'm not sure if there are benefits for one over the other, but it's good for the record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a set of tests to check that JPEG loading functions do not hang when supplying truncated/corrupt images. Now torchvision will raise an exception whenever an incomplete image is loaded.