Skip to content

Make RandomVerticalFlip torchscriptable #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Make RandomVerticalFlip torchscriptable #2283

merged 2 commits into from
Jun 4, 2020

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Jun 2, 2020

This is a follow-up of #2282, trying to stack PRs by hand.

@fmassa fmassa requested a review from eellison June 2, 2020 14:44
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me - let's rresolve the nn.Module / normal class question in the other thread

@fmassa fmassa merged commit 9c20193 into hflip-script Jun 4, 2020
@fmassa fmassa deleted the vflip-script branch June 4, 2020 15:54
fmassa added a commit that referenced this pull request Jun 4, 2020
* Make RandomHorizontalFlip torchscriptable

* Make _is_tensor_a_torch_image more generic

* Make RandomVerticalFlip torchscriptable (#2283)

* Make RandomVerticalFlip torchscriptable

* Fix lint
@fmassa fmassa mentioned this pull request Jun 5, 2020
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants