-
Notifications
You must be signed in to change notification settings - Fork 7.2k
[ONNX] Fix model export for images w/o detection #2126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…of/fixNoDetection # Conflicts: # torchvision/models/detection/transform.py
… into neraoof/fixDynamicResize
…on into neraoof/fixDynamicResize
…of/fixDynamicResize
…of/fixDynamicResize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Negin!
Let's wait until the PyTorch PR gets merged and CI is green before merging this.
I believe once support for numel()
is added, we will be able to simplify a few things we did in the past that used numel()
.
…of/fixDynamicResize
…of/fixDynamicResize
…of/fixDynamicResize
…of/fixDynamicResize
…on into neraoof/fixDynamicResize
…on into neraoof/fixDynamicResize
Codecov Report
@@ Coverage Diff @@
## master #2126 +/- ##
======================================
Coverage 0.48% 0.48%
======================================
Files 92 92
Lines 7433 7433
Branches 1133 1133
======================================
Hits 36 36
Misses 7384 7384
Partials 13 13 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
* Fixing nms on boxes when no detection * test * Fix for scale_factor computation * remove newline * Fix for mask_rcnn dynanmic axes * Clean up * Update transform.py * Fix for torchscript * Fix scripting errors * Fix annotation * Fix lint * Fix annotation * Fix for interpolate scripting * Fix for scripting * refactoring * refactor the code * Fix annotation * Fixed annotations * Added test for resize * lint * format * bump ORT * ort-nightly version * Going to ort 1.1.0 * remove version * install typing-extension * Export model for images with no detection * Upgrade ort nightly * update ORT * Update test_onnx.py * updated tests * Updated tests * merge * Update transforms.py * Update cityscapes.py * Update celeba.py * Update caltech.py * Update pkg_helpers.bash * Clean up * Clean up for dynamic split * Remove extra casts * flake8
batched_nms needs to be scripted to capture the code flow and support export of model for images with no detection.