-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Checking clang-format for C++ side #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
- Coverage 65.52% 65.14% -0.39%
==========================================
Files 74 74
Lines 5784 5784
Branches 884 786 -98
==========================================
- Hits 3790 3768 -22
- Misses 1727 1742 +15
- Partials 267 274 +7
Continue to review full report at Codecov.
|
@fmassa I think that the PR is ready. But there are errors in the format of some files:
Should I fix these here or in another PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @ShahriarSS ! Can you send a separate PR with this fix? I think the failing CI should be fine, given that this is a separate build instance.
This is a PR adding clang-format check to
C++
code.