-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Added evaluation code for VOC Pascal dataset #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the PR @lpuglia !
I don't have much time to review it now. I'm going on holidays now for a couple of weeks, back on Aug 25th), but I think there are a few things that can be improved (i.e., avoid having a duplicate voc_evaluate
). I'll give more detailed comments once I'm back from holidays!
Hello @lpuglia and sorry for the taking that long for an update. As far as my understanding goes, it seems that in general, the In the meantime, there is a new datasets API being designed and since you use an existing dataset (namely
That being said, before embarking on this development, let's first check if this feature is still needed. Have you used this branch in some work or do you use another project to do this VOC Pascal evaluation? Or maybe another alternative? Please share if this feature is still relevant @lpuglia. Many thanks in advance and sorry again for the delay. |
@yassineAlouini This PR does not add a new dataset. The VOC detection dataset is supported in the old vision/torchvision/datasets/voc.py Line 177 in a1232c2
as well as the new API:
This PR adds support for this dataset in the reference training scripts, which only supports COCO vision/references/detection/train.py Line 37 in a1232c2
@lpuglia As @yassineAlouini mentioned, we are currently redesigning the datasets as well as the transforms. This in turn means that we also will adapting the reference scripts quite a bit and it should be easier to add new datasets. IIUC, the major part of this contribution is to implement the evaluation method used for VOC. There shouldn't be much changes there, so we can port easily. That being said, we are trying to close stale PRs. I would open an issue linking this PR so we don't forget (again) about this and close the PR for now. How does that sound? |
I'm ok to close this, the feature is not needed anymore |
With the following PR it is possible to train FasterRCNN network using VOC dataset.
It was tested on
fasterrcnn_resnet50_fpn
and got over 70% mAp in 10 epochs.python train.py --dataset voc --epochs 15 --lr-steps 10 -b 4 --lr 0.04 --model fasterrcnn_resnet50_fpn --data-path /data/set/
notes:
int8
, this is not as clean as parsing the actual image number, but it generalize better if used on other dataset that have more complex indexing system (e.g. WIDER FACE)