add simplefsdp's autobucketing pass entry #1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruisizhang123
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
ruisizhang123
force-pushed
the
add_ruisi_pass
branch
from
481f97a to
42ab5e2
Compare
ruisizhang123
changed the title
ruisizhang123
force-pushed
the
add_ruisi_pass
branch
2 times, most recently
from
0d720ca to
2bc0566
Compare
ruisizhang123
changed the title
ruisizhang123
force-pushed
the
add_ruisi_pass
branch
2 times, most recently
from
08530ea to
8feb867
Compare
xmfan
reviewed
Sep 5, 2025
torchtitan/train.py
Outdated
| torch._inductor.config.reorder_for_peak_memory = False | ||
| torch._inductor.config.reorder_for_compute_comm_overlap = True | ||
| simplefsdp_autobucketing_config.save_estimation_path = ( | ||
| "/tmp/estimation_mast.pkl" |
Member
There was a problem hiding this comment.
a file name more specific to torchtitan/simple fsdp to avoid conflicts
Member
|
please only land once all pytorch changes are landed |
xmfan
approved these changes
Sep 5, 2025
ruisizhang123
force-pushed
the
add_ruisi_pass
branch
from
8feb867 to
7d1bb0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled, this pr adds entry to simplefsdp's autobucketing pass in autoparallel. original code is in: pytorch/pytorch#160282
The main code for autobucketing pass will be added to autoparallel repo.