Skip to content

Reorder validate and checkpoint in train #1542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianyu-l merged 1 commit into from
Aug 8, 2025
Merged

Reorder validate and checkpoint in train #1542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions torchtitan/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,17 +575,17 @@ def train(self):
logger.warning("Ran out of data; last step was canceled.")
break

self.checkpointer.save(
self.step, last_step=(self.step == job_config.training.steps)
)

# Run validation if validator is available
if (
self.job_config.validation.enabled
and self.validator.should_validate(self.step)
):
self.validator.validate(self.model_parts, self.step)

self.checkpointer.save(
self.step, last_step=(self.step == job_config.training.steps)
)

# signal the profiler that the next profiling step has started
if torch_profiler:
torch_profiler.step()
Expand Down
Loading