Add res parameters to SplitTableBatchedEmbeddingBagsCodegen #3330
+63
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D80503597 |
chouxi
added a commit
to chouxi/torchrec
that referenced
this pull request
Aug 28, 2025
…3330) Summary: Adding RES to SplitTableBatchedEmbeddingBagsCodegen The parameter populate logic is the similar existing one in _populate_ssd_tbe_params so extract them to a function. Now pulling everything from fused params to be reused by UVM_CACHE and SSD modes. The logic in addition here is the additional res_enabled_tables, only enable the RES for specific TBE when it contains enabled tables. - This is needed because currently we only want to enable it for one table and don't want to overhead for other tbes. Differential Revision: D80503597
chouxi
force-pushed
the
export-D80503597
branch
from
8a06f7e to
a7f245b
Compare
chouxi
added a commit
to chouxi/torchrec
that referenced
this pull request
Aug 28, 2025
…3330) Summary: Adding RES to SplitTableBatchedEmbeddingBagsCodegen The parameter populate logic is the similar existing one in _populate_ssd_tbe_params so extract them to a function. Now pulling everything from fused params to be reused by UVM_CACHE and SSD modes. The logic in addition here is the additional res_enabled_tables, only enable the RES for specific TBE when it contains enabled tables. - This is needed because currently we only want to enable it for one table and don't want to overhead for other tbes. Differential Revision: D80503597
chouxi
force-pushed
the
export-D80503597
branch
from
a7f245b to
bee3af4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80503597 |
chouxi
added a commit
to chouxi/torchrec
that referenced
this pull request
Aug 28, 2025
…3330) Summary: Pull Request resolved: pytorch#3330 Adding RES to SplitTableBatchedEmbeddingBagsCodegen The parameter populate logic is the similar existing one in _populate_ssd_tbe_params so extract them to a function. Now pulling everything from fused params to be reused by UVM_CACHE and SSD modes. The logic in addition here is the additional res_enabled_tables, only enable the RES for specific TBE when it contains enabled tables. - This is needed because currently we only want to enable it for one table and don't want to overhead for other tbes. Differential Revision: D80503597
chouxi
force-pushed
the
export-D80503597
branch
from
bee3af4 to
a9b3488
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80503597 |
chouxi
force-pushed
the
export-D80503597
branch
from
a9b3488 to
f10f8a5
Compare
chouxi
added a commit
to chouxi/torchrec
that referenced
this pull request
Aug 28, 2025
…3330) Summary: Pull Request resolved: pytorch#3330 Adding RES to SplitTableBatchedEmbeddingBagsCodegen The parameter populate logic is the similar existing one in _populate_ssd_tbe_params so extract them to a function. Now pulling everything from fused params to be reused by UVM_CACHE and SSD modes. The logic in addition here is the additional res_enabled_tables, only enable the RES for specific TBE when it contains enabled tables. - This is needed because currently we only want to enable it for one table and don't want to overhead for other tbes. Differential Revision: D80503597
chouxi
force-pushed
the
export-D80503597
branch
from
f10f8a5 to
deee1f2
Compare
chouxi
added a commit
to chouxi/torchrec
that referenced
this pull request
Sep 3, 2025
…3330) Summary: Adding RES to SplitTableBatchedEmbeddingBagsCodegen The parameter populate logic is the similar existing one in _populate_ssd_tbe_params so extract them to a function. Now pulling everything from fused params to be reused by UVM_CACHE and SSD modes. The logic in addition here is the additional res_enabled_tables, only enable the RES for specific TBE when it contains enabled tables. - This is needed because currently we only want to enable it for one table and don't want to overhead for other tbes. Reviewed By: yixin94 Differential Revision: D80503597
…3330) Summary: Pull Request resolved: pytorch#3330 Adding RES to SplitTableBatchedEmbeddingBagsCodegen The parameter populate logic is the similar existing one in _populate_ssd_tbe_params so extract them to a function. Now pulling everything from fused params to be reused by UVM_CACHE and SSD modes. The logic in addition here is the additional res_enabled_tables, only enable the RES for specific TBE when it contains enabled tables. - This is needed because currently we only want to enable it for one table and don't want to overhead for other tbes. Reviewed By: yixin94, yingufan Differential Revision: D80503597
|
This pull request was exported from Phabricator. Differential Revision: D80503597 |
chouxi
force-pushed
the
export-D80503597
branch
from
deee1f2 to
fd1c34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding RES to SplitTableBatchedEmbeddingBagsCodegen
The parameter populate logic is the similar existing one in _populate_ssd_tbe_params so extract them to a function.
Now pulling everything from fused params to be reused by UVM_CACHE and SSD modes.
The logic in addition here is the additional res_enabled_tables, only enable the RES for specific TBE when it contains enabled tables.
Differential Revision: D80503597